Fix/support flask 2 and flask 1 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic!! Thanks for this PR! <3 |
Closed
|
@StefanVDWeide Could you update |
|
@vimalloc I've gone ahead and implemented a kind of hacky way to test Flask 1 for each version of python by adding it as an extra step to the Github Actions workflow. I'm not very experienced with Tox so I'm open to suggestions for improvements :) |
|
Awesome. I think running it in every python version might not be necessary, but this totally works so I'm not complaining at all. Thanks so much for getting this handled! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a first stab at making the check for the major Flask version more robust. I've also specified a new test environment in tox which specifically uses Flask 1.1.4, the last major 1.x.x version.