- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make header reading compliant with RFC7230, section 3.2.2 #270
Conversation
I had no idea that was valid, thanks for the pull request! If you don't mind, could you throw a quick unit test around this this? Then I will get it merged and a new release cut ASAP. Thanks! |
Yeah no problem, I will get them set up tonight. |
I've added the unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor things, if you could get those changed and fix the pep8 errors (#270 (comment)) I think this should be good to go.
Thanks for contributing!
Sorry for the delay in getting back to you, I was not around this weekend. I left a couple comments, if you can update those I think this looks great and I could get a new release cut. Thanks! |
2fc098e
to
58850a8
Compare
Alright, finally managed to fix all the pep8 issues, my editor was exhibiting some weird behavior that kept creating new issues, but it should all be good now, I also fixed the ambiguity call when multiple header fields have the same value and reverted the config change |
Thanks! I'll get a new release cut stat. |
Released as version 3.23.0. Thanks for contributing! 👍 |
RFC7230, section 3.2.2 specifies that headers can be joined by comma separating the values so a header like this
Authorization: Bearer <JWT>, Basic <B64EncodedCreds>
is valid