audience verification, more flexible token decoding & decode key callback

[acrossen]

per #208

[pep8speaks]

Hello @acrossen! Thanks for updating the PR.

• There are no PEP8 issues in the file flask_jwt_extended/config.py !

• There are no PEP8 issues in the file flask_jwt_extended/default_callbacks.py !

• There are no PEP8 issues in the file flask_jwt_extended/jwt_manager.py !

• There are no PEP8 issues in the file flask_jwt_extended/tokens.py !

• In the file flask_jwt_extended/utils.py, following are the PEP8 issues :

Line 87:91: E501 line too long (101 > 90 characters)
Line 88:91: E501 line too long (104 > 90 characters)

• There are no PEP8 issues in the file tests/test_decode_tokens.py !

• There are no PEP8 issues in the file tests/test_view_decorators.py !

Comment last updated on December 06, 2018 at 19:33 Hours UTC

[vimalloc]

This is looking good! I left a few notes for minor changes in a couple places. If we can get those updated I would feel comfortable merging this 👍

[vimalloc]

Thanks @acrossen that looks good. One last question for you (sorry I missed this in the original review). Do we need to add an error handler for the InvalidAudienceError in here: https://github.com/vimalloc/flask-jwt-extended/blob/master/flask_jwt_extended/jwt_manager.py#L95

It would be awesome if we could add one more unit test to cover that code path, ie that in a real flask request, giving a token with a bad aud will trigger the self._invalid_token_callback function.
But otherwise this looks great.

Nice job putting this together, and thanks for the hard work you’ve done on it! 👍

[coveralls]

Coverage remained the same at 100.0% when pulling 03a5a57 on acrossen:google_oidc_token_validation into 6fe88c7 on vimalloc:master.