Add tox.ini and tests in MANIFEST.in #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimalloc
approved these changes
Sep 27, 2018
|
Looks good to me. I'll get a second person to rubber stamp this, then get a new release cut for you. Thanks for contributing! 👍 |
|
Nice idea. Never can have enough tests. |
Nimor111
approved these changes
Sep 27, 2018
|
This has been released in version 3.13.1. Cheers! 👍 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the
testsdirectory and thetox.iniinMANIFEST.into be able to run the tests after installing the source via PyPi to check if the installation ran successfully.Motivation analogous to NixOS/nixpkgs#45871 (comment) because I want to add this package to nixpkgs.