Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little optimization #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RestorerZ
Copy link
Contributor

Reduced the download size of the installation file of the program Python ver. 3.
Reduced dependency on third-party tools such as cygwin and jq.
Where possible, a linking mechanism has been used instead of copying files.
Other.

Execution time of “install”, “build” and “package” sections without dependency
downloading:
it was
x64 - 631.769sec.
x86 - 657.733sec.
it became
x64 - 328.226sec.
x86 - 335.175sec.

@RestorerZ RestorerZ marked this pull request as draft January 14, 2025 18:20
@RestorerZ RestorerZ marked this pull request as ready for review January 15, 2025 18:48
@chrisbra
Copy link
Member

can you please rebase?

What is the purpose of additional patch? Ideally we wouldn't need an extra patch here.

Also please in the future keep the style and don't change it. It makes reviewing harder if you e.g. change nmake to nmake.exe or nmake -f to nmake -lf. Or at least use a separate commit for those stylistic chagnes. This makes reviewing much harder otherwise.

@RestorerZ
Copy link
Contributor Author

Christian, the patch-file here was needed for testing.

Yeah, sure, I'll rebase it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants