Recover smart punctuation related contributions #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
force-pushed
the
rwxrob/smart-quotes
branch
from
c952334 to
ee59c57
Compare
|
Status: I've messed around with this some and the syntax rules definitely do fix some cases that were broken before. At the same time they also break quite a few cases that were fine before. For example: *'bar'*In master the conceal for the italic works just fine. In these patches it also eats the right side of the quote. Meanwhile ellipses conceals seem to be broken for me in both versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to salvage all the bits of #312 and #313 that are in shape to be contributed to the main plugin (basically everything except the syntax highlighting overrides which I believe should be either left to themes or at least made optional).