-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌿 add/improve tests for interrupt #422
Conversation
WalkthroughThe changes introduce enhancements to the testing of the Changes
Possibly related PRs
Suggested reviewers
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (5)
Files skipped from review as they are similar to previous changes (4)
Additional comments not posted (13)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 25 25
Lines 1416 1416
Branches 180 180
=======================================
Hits 1359 1359
Misses 55 55
Partials 2 2 ☔ View full report in Codecov by Sentry. |
@coderabbitai review |
Actions performedReview triggered.
|
ef6fd3f
to
e88220a
Compare
I've included fixes for flaky tests for |
55e6246
to
116dc1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is fixed re-opened PR of #421.
Summary by CodeRabbit
New Features
denops#interrupt()
function to validate its behavior under various conditions.denops#notify()
anddenops#request_async()
functions to ensure robust error handling and event validation.DenopsImpl
class with improved interruption logic validation.Bug Fixes
Documentation