👍 no package json #414
👍 no package json #414
Conversation
WalkthroughThe recent changes introduce a new environment variable, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Deno
participant Proc
User->>Proc: Start process
Proc->>Deno: Set environment variable DENO_NO_PACKAGE_JSON = 1
Deno->>Proc: Initialize with new settings
Proc->>User: Process started with modified environment
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- autoload/denops/_internal/server/proc.vim (1 hunks)
Additional comments not posted (1)
autoload/denops/_internal/server/proc.vim (1)
58-58: LGTM!The addition of the
DENO_NO_PACKAGE_JSONenvironment variable aligns with the PR objective to eliminate the use of thepackage.jsonfile and prevent the automatic creation of anode_modulesdirectory.The code changes are approved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 23 23
Lines 1384 1384
Branches 174 174
=======================================
Hits 1321 1321
Misses 60 60
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Do not use the package.json file.
Do not create the node_modules directory.
For example, some Vim plugins have the package.json file and directories are merged by the Vim package manager.
If the package.json file is exists, then
deno runuse it and create the node_modules directory automatically.Summary by CodeRabbit
DENO_NO_PACKAGE_JSON, enhancing configuration options for the Deno runtime environment. This allows for more control over package resolution and initialization behavior.