-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Changed to relative link #17
Conversation
WalkthroughThe pull request modifies documentation files related to Denops and Vim plugins, enhancing clarity and depth. Changes include an expanded explanation of Denops functionality, plugin registration processes, and the structure of Denops plugins. Additionally, updates to example code demonstrate command registration and autocmd usage. The documentation now provides a more comprehensive overview of available methods on the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/getting-started/explanation.md
(1 hunks)src/tutorial/helloworld/calling-vim-features.md
(1 hunks)
🔇 Additional comments (2)
src/tutorial/helloworld/calling-vim-features.md (2)
Line range hint 8-26
: Well-structured TypeScript implementation!
The code demonstrates good practices:
- Proper type safety with
unknownutil
assertions - Clear separation of command registration and handler logic
- Appropriate use of JSR imports with version constraints
Line range hint 28-38
: Vim script follows best practices!
The implementation includes all necessary safeguards:
- Proper guard against double loading
- Correct autocmd group management
- Appropriate event handling for plugin initialization
#16 にて、絶対パスを指定したらリンクが壊れてしまったので、相対パスに戻した
deno fmt
を実行したSummary by CodeRabbit
New Features
Documentation