some SSAIR pass improvements: (JuliaLang#43221)

- improve type stability around `perform_lifting!` - avoid using mutable `RefValue`s - add docstrings for `lift_comparison!` / `canonicalize_typeassert!` - fix `@nospecialize` annotation for `simple_walk_constraint`
vilterp · Nov 25, 2021 · d31ba7c · d31ba7c
1 parent 3103102
commit d31ba7c
Show file tree

Hide file tree

Showing 3 changed files with 189 additions and 149 deletions.
diff --git a/base/compiler/ssair/ir.jl b/base/compiler/ssair/ir.jl
@@ -719,7 +719,7 @@ function insert_node!(compact::IncrementalCompact, before, inst::NewInstruction,
     elseif isa(before, OldSSAValue)
         pos = before.id
         if pos < compact.idx
-            renamed = compact.ssa_rename[pos]
+            renamed = compact.ssa_rename[pos]::AnySSAValue
             count_added_node!(compact, inst.stmt)
             line = something(inst.line, compact.result[renamed.id][:line])
             node = add!(compact.new_new_nodes, renamed.id, attach_after)