Add flake8 to project and lint step

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+max-line-length = 88

.github/workflows/push.yaml

@@ -14,9 +14,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v1
       - name: Install Dev Dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install -r dev-requirements.txt
+        run: pip install -r dev-requirements.txt
       - name: Lint Templates
         run: make lint
 
@@ -32,9 +30,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v1
       - name: Install Dev Dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install -r dev-requirements.txt
+        run: pip install -r dev-requirements.txt
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:
@@ -56,9 +52,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v1
       - name: Install Dev Dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install -r dev-requirements.txt
+        run: pip install -r dev-requirements.txt
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:

Makefile

@@ -10,7 +10,8 @@ endif
 
 lint:
 	black . --check
-	pylint test/*.py functions/*.py
+	flake8 .
+	pylint **/*.py
 	cfn-lint templates/*.template
 
 nuke:

dev-requirements.txt

@@ -1,8 +1,9 @@
 git+git://github.com/PyCQA/astroid.git#egg=astroid
 awscli
 black
+cfn-flip
 cfn-lint
-cfn-tools
+flake8
 git+git://github.com/PyCQA/pylint.git#egg=pylint
 pytest
 taskcat

examples/project/airflow/dags/my_dag.py

@@ -1,7 +1,6 @@
 from datetime import datetime
 
-import airflow
-from airflow.models import DAG
+from airflow import DAG
 from airflow.operators.bash_operator import BashOperator
 
 default_args = {

functions/load_metric.py

@@ -79,7 +79,7 @@ def get_metrics(timestamp):
                         "Namespace": "AWS/AutoScaling",
                         "MetricName": "GroupInServiceInstances",
                         "Dimensions": [
-                            {"Name": "AutoScalingGroupName", "Value": f"{group}",}
+                            {"Name": "AutoScalingGroupName", "Value": f"{group}"}
                         ],
                     },
                     "Period": 300,