Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple translation issues + RU lang file #386

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Conversation

phpony
Copy link
Contributor

@phpony phpony commented Nov 26, 2023

This pull request covers multiple translation issues:

  1. Menu is not translated until first interaction;
  2. Toolbar labels are not translatable at all;
  3. Unnecessary spacers at the end of toolbar's labels;
  4. "Colors", "Details" and "Layers" boxes translation.

Also there's a complete RU lang file.

<label> elements in toolbar should have "tr" class to be translatable too.
Menu is not being translated from page load till first interaction with it. Should call translate after render_main().
We don't need space symbols at the end of label HTML. Spacing is done in CSS anyway.
@phpony phpony changed the title Multiple translation issues Multiple translation issues + RU lang file Nov 26, 2023
@viliusle viliusle merged commit 8189d9c into viliusle:master Dec 1, 2023
@viliusle
Copy link
Owner

viliusle commented Dec 1, 2023

Thank you for PR.
Everything looks good, I found 1 missing include (fixed). I also re-imported latest translations using Google auto-translate, but your added translations should remain as higher priority. Let me know if you will find issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants