Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] Prevent Block IDs from Changing #140

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

bd-viget
Copy link
Contributor

Summary

This PR is a bug fix that resets the Block IDs transient at the start of a new request to ensure a new set of IDs is being used when creating Block IDs and checking for duplicates.

Issues

  • N/A/

Testing Instructions

  1. Using a block that supports block_id, add one or more to a page.
  2. Make changes and save within 1 min of the previous save
  3. Ensure the Block ID(s) have not changed. ($block['block_id'])

Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is awesome!

@bd-viget bd-viget merged commit 62c3db0 into main Jul 31, 2024
@bd-viget bd-viget deleted the bd/unique-block-id-bug-fix branch July 31, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants