parse x-timestamp-map #4
Conversation
| }, /[^\d]:/, /,/); | ||
|
|
||
| self.ontimestampmap && self.ontimestampmap({ | ||
| "MPEGTS": settings.get("MPEGTS"), |
There was a problem hiding this comment.
And by this, I mean LOCA and MPEGT.
There was a problem hiding this comment.
This also needs to be rebased against master. I've been doing some housekeeping to make it easier for us to publish our fork of vttjs.
Does this require a follow up PR for more functionality, as asked in the line comment?
Also, I think some docs in the README would be nice.
| }, /:/); | ||
| }, /[^\d]:/, /,/); | ||
|
|
||
| self.ontimestampmap && self.ontimestampmap({ |
There was a problem hiding this comment.
so, ontimestampmap is a method on the parser that will be called with the MPEGTS and LOCAL times? Does it mean that the user still needs to manually shift all the timestamps by this?
There was a problem hiding this comment.
Yes, the user would have to manually shift the timestamps. The timestamp map tag only gives a mapping from cue time to TS time, but the mapping from TS to display time is still needed for the shift. I think this approach is the easiest instead of storing state on the parse for the extra mapping
There was a problem hiding this comment.
hm... maybe it's the best option; it just seems to be only half complete this way.
mjneil
force-pushed
the
x-timestamp-map
branch
from
b41a9a4 to
70ada60
Compare
mjneil
force-pushed
the
x-timestamp-map
branch
2 times, most recently
from
42bc909 to
5003c5f
Compare
|
@gkatsev Can we please just get this merged before we decide what to do about vtt.js in the longer term? |
mozilla/vtt.js#362