docs: Add useSVGIcons option #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wseymour15
commented
May 2, 2023
src/mdx-pages/guides/options.mdx
Outdated
|
|
||
| > Type: `boolean` | ||
|
|
||
| _Since 8.4.0_ |
There was a problem hiding this comment.
This is assuming this gets released in the next version, but will be changed if that is not the case.
7 tasks
adrums86
approved these changes
Jun 9, 2023
amtins
reviewed
Jun 11, 2023
src/mdx-pages/guides/options.mdx
Outdated
| @@ -615,6 +615,20 @@ Override the mute key definition. If this is set, the function receives the `key | |||
|
|
|||
| Override the play/pause key definition. If this is set, the function receives the `keydown` event; if the function returns `true`, then the play/pause toggle action is performed. | |||
|
|
|||
| ### `experimentalSvgIcons` | |||
There was a problem hiding this comment.
I have a question about the position of this option. I noticed that the other options were arranged in alphabetical order. Should there be some consistency? Or was this done on purpose because it's an experimental option?
There was a problem hiding this comment.
Good catch, this was in alphabetical order until I updated the name of the option. I just pushed a commit to update this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents
useSVGIconsplayer option for videojs/video.js#8260