chore: update build tooling to drop older browser support #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-barstow
commented
Jan 25, 2023
| @@ -1,7 +1,7 @@ | |||
| import {version as VERSION} from '../package.json'; | |||
| import window from 'global/window'; | |||
| import document from 'global/document'; | |||
| import WebVRPolyfill from 'webvr-polyfill'; | |||
| import WebVRPolyfill from 'webvr-polyfill/src/webvr-polyfill'; | |||
There was a problem hiding this comment.
The WebVRPolyfill module doesn't have ES6 build output, and @rollup/plugin-commonjs apparently has problems bundling it into our build output. I experimented with various other rollup plugins, but wasn't successful in getting it to work. However, importing from the src/ directory, which does export an ES6 module, does seem to work.
|
I think we should get #273 merged in before this |
|
After some offline discussion we decided it's OK to merge this in before #273. |
misteroneill
approved these changes
Feb 10, 2023
mister-ben
pushed a commit
to mister-ben/videojs-vr
that referenced
this pull request
Dec 4, 2023
BREAKING CHANGE: This drops support for older browsers such as IE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: BREAKING CHANGE!
This updates the default browserslist used by babel. It drops support for some older browsers including IE 11. This also removes the browserslist in package.json so we use the default list from @videojs/babel-config (linked above).