-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Swap webvr to webxr polyfill packages #273
Open
kevleyski
wants to merge
115
commits into
videojs:main
Choose a base branch
from
MetaCDN:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
115 commits
Select commit
Hold shift + click to select a range
d742fd1
Updating node-sass version (to remove python2 dependency)
d3fba93
Husky update
139f797
[KJSL] Swap webvr ro webxr polyfill packages
a46b98d
Example of having both polyfills - rewritting plugin.js to use the ne…
kevleyski dc28b05
[KJSL] Swap webvr ro webxr polyfill packages
f41dc2a
Merge pull request #1 from kevleyski/main
kevleyski dbc1073
[KJSL] Swap webvr ro webxr polyfill packages
cd30806
[KJSL] Swap webvr ro webxr polyfill packages
eecdbba
Merge pull request #2 from kevleyski/main
kevleyski d6821ab
[KJSL] Swap webvr ro webxr polyfill packages
842abed
Merge pull request #3 from kevleyski/main
kevleyski 6de443d
[KJSL] Swap webvr ro webxr polyfill packages
b318d28
[KJSL] Swap webvr ro webxr polyfill packages
6d4ff0a
[KJSL] Swap webvr ro webxr polyfill packages
e02ce1d
Merge pull request #4 from kevleyski/main
kevleyski 70a1611
chore: Swap webvr ro webxr polyfill packages
e0d1c48
Merge pull request #5 from kevleyski/main
kevleyski 36e7cdc
chore: Swap webvr ro webxr polyfill packages (continue to use webvr p…
c8330f7
Merge pull request #6 from kevleyski/main
kevleyski 56ad5f3
chore: Swap webvr ro webxr polyfill packages (adding basic controller…
a8d1459
Merge pull request #7 from kevleyski/main
kevleyski 856a183
chore: Swap webvr ro webxr polyfill packages (add iOS permission chec…
8d88ec5
Merge pull request #8 from kevleyski/main
kevleyski 7c0c62b
chore: Swap webvr ro webxr polyfill packages (add iOS permission chec…
46c7207
Merge pull request #9 from kevleyski/main
kevleyski 7bf68a5
Update src/big-vr-play-button.js
kevleyski 1cc47ef
Update src/plugin.js
kevleyski 13d2b02
Merge pull request #1 from MetaCDN/main
kevleyski 2603836
chore: Swap webvr for webxr polyfill packages (PR fix ups)
ff858af
chore: Swap webvr for webxr polyfill packages (PR fix ups)
de6db15
Merge pull request #10 from kevleyski/main
kevleyski 80f9e0c
chore: Swap webvr for webxr polyfill packages (PR fix ups - part reve…
448eb88
chore: Swap webvr for webxr polyfill packages (PR fix ups - only show…
8fb0579
Merge pull request #11 from kevleyski/main
kevleyski 538dca1
(revert accidental file delete)
cf6277d
chore: Swap webvr for webxr polyfill packages (PR fix ups - clicking …
07c7f54
chore: Swap webvr for webxr polyfill packages (PR fix ups - clicking …
c5c6a58
Merge pull request #12 from kevleyski/main
kevleyski 35ed850
chore: Swap webvr for webxr polyfill packages (PR fix ups - testing o…
8441f77
Merge pull request #13 from kevleyski/main
kevleyski 9ce1f15
chore: Swap webvr for webxr polyfill packages (PR fix ups - testing o…
a6528ac
chore: Swap webvr for webxr polyfill packages (PR fix ups - adding 18…
33d206b
Merge pull request #14 from kevleyski/main
kevleyski 91cfea0
chore: Swap webvr for webxr polyfill packages (PR fix ups - adding 18…
b0ebafd
Merge pull request #15 from kevleyski/main
kevleyski dc23443
chore: Swap webvr for webxr polyfill packages (PR fix ups - deprecate…
72ae5d3
Merge pull request #16 from kevleyski/main
kevleyski 62c45b4
three version up
kevleyski 0e1c4a1
three version up
kevleyski 3261832
(three.js version)
kevleyski 9ed1171
Merge pull request #17 from kevleyski/main
kevleyski b180074
three.js version API differences
kevleyski 55d53dc
Merge pull request #18 from kevleyski/main
kevleyski 8adb558
three.js version API differences (part revert to allow webvr to still…
kevleyski 3264b5e
Merge pull request #19 from kevleyski/main
kevleyski f8ea3cb
three.js version revert back to v129 as 130 breaks renderer.getSize
kevleyski c9f5903
Merge pull request #20 from kevleyski/main
kevleyski 466267b
cubemap verticies
kevleyski da9c89c
fix up 180 mono
kevleyski c3b9b4f
Merge pull request #21 from kevleyski/main
kevleyski c4bd610
Move to latest THREE.js (0.149.0)
kevleyski a4c12ac
Use latest THREE.js
kevleyski 3786a9d
Merge pull request #22 from kevleyski/main
kevleyski 5943617
chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up VR…
70c5f29
Merge pull request #23 from kevleyski/main
kevleyski 37fe825
chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up 18…
e444322
Merge pull request #24 from kevleyski/main
kevleyski d890f20
chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)
89ab083
chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)
dc27ea8
chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)
cd05e47
Merge pull request #25 from kevleyski/main
kevleyski a2b1aa0
chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap b…
ad1b413
Merge pull request #26 from kevleyski/main
kevleyski c58338c
chore: Swap webvr for webxr polyfill packages (PR fix ups - UI) (#27)
kevleyski 4a58148
(more tests/examples)
kevleyski 48fd17b
(more tests/examples)
kevleyski 46fd3b1
(fix up PR #273 merge)
kevleyski 4d2165d
videojs-vr v2.1.0 (baseline pre merge from videojs github)
0386ec1
Test husky
842651e
Updated README
jbroberg 855e04c
Husky test
01d12fd
Updated README
jbroberg 4e19fa3
Merge branch 'main' of https://github.com/MetaCDN/videojs-vr
jbroberg 1e971cd
Fixup Ellipsoidal Cube Maps
ad6dd0f
Fixing Equi-Angular Cubemap
48e84fa
Fixing Equi-Angular Cubemap
0581199
fix readme typos
jbroberg 3650987
Fixing Equi-Angular Cubemap orientation
8a41917
Merge remote-tracking branch 'origin/main'
cc00e6f
THREE.js buffer geometry refactor
ab66880
Cleanup, bump three and external imports
jbroberg 58ab5ba
Disable Cardboard by default
jbroberg 36345dd
(remove cardboard)
e00f3a9
KJSL: reviving DeviceOrientationControls for where we've removed Card…
26c4ef1
KJSL: Reviving DeviceOrientationControls for iPhone
1293cbd
KJSL: Reviving DeviceOrientationControls for iPhone
2297edd
KJSL: Reviving DeviceOrientationControls for iPhone
8685bb5
KJSL: Reviving DeviceOrientationControls for iPhone
5de1366
KJSL: Reviving DeviceOrientationControls for iPhone
888a390
KJSL: devices fill the screen more
ebbf917
KJSL: devices fill the screen more
8b44f0c
KJSL: moving example UI image to dist, this will later be separated
f7a1c4e
KJSL: latest rollup image plugin didn't seem to work with other maybe…
d131def
KJSL: update to latest THREE.js
92f9182
Allow passing in M3U8 or MPD as the QUERY_STRING
a3145b5
Fix up exception and green button
3c9efb8
Resize timing bug around webxr-polyfill (getEyeParameters)
6f845f5
Resize timing bug around webxr-polyfill (getEyeParameters)
ec34d00
Resize timing bug around webxr-polyfill (getEyeParameters)
0c90edc
Rollback THREE.js to earlier version which didnt have brightness/gamm…
e89683f
KJSL: v2.1.1
3be5577
KJSL: v2.1.1
cea8a83
KJSL: v2.1.2 Android can use native cardboaard support instead
b5ddaa5
Merge remote-tracking branch 'origin/jimdevel'
5f5ce22
KJSL: v2.1.2 Android can use native cardboard support instead
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/usr/bin/env sh | ||
. "$(dirname -- "$0")/_/husky.sh" | ||
|
||
node_modules/.bin/lint-staged |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<projectDescription> | ||
<name>videojs-vr</name> | ||
<comment></comment> | ||
<projects> | ||
</projects> | ||
<buildSpec> | ||
</buildSpec> | ||
<natures> | ||
</natures> | ||
</projectDescription> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<!doctype html> | ||
<html> | ||
<head> | ||
<meta charset="utf-8"> | ||
<title>videojs-vr Demo</title> | ||
<link href="../node_modules/video.js/dist/video-js.css" rel="stylesheet"> | ||
<link href="../dist/videojs-vr.css" rel="stylesheet"> | ||
</head> | ||
<body> | ||
<video width="640" height="300" id="videojs-vr-player" class="video-js vjs-default-skin" controls playsinline> | ||
<source src="https://kevleyski.github.io/reckless_in_pyrmont/hls_fmp4_byterange/reckless_in_pyrmont.m3u8" type="application/vnd.apple.mpegurl"> | ||
</video> | ||
<ul> | ||
<li><a href="../">return to main example</a></li> | ||
</ul> | ||
<script src="../node_modules/video.js/dist/video.js"></script> | ||
<script src="../dist/videojs-vr.js"></script> | ||
<script> | ||
(function(window, videojs) { | ||
var player = window.player = videojs('videojs-vr-player'); | ||
player.mediainfo = player.mediainfo || {}; | ||
player.mediainfo.projection = '180_MONO'; | ||
|
||
var vr = window.vr = player.vr({projection: '180_MONO', debug: true, forceCardboard: false}); | ||
}(window, window.videojs)); | ||
</script> | ||
|
||
<script src="examples.js"></script> | ||
|
||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<!doctype html> | ||
<html> | ||
<head> | ||
<meta charset="utf-8"> | ||
<title>videojs-vr Demo</title> | ||
<link href="../node_modules/video.js/dist/video-js.css" rel="stylesheet"> | ||
<link href="../dist/videojs-vr.css" rel="stylesheet"> | ||
</head> | ||
<body> | ||
<video width="640" height="300" id="videojs-vr-player" class="video-js vjs-default-skin" controls playsinline> | ||
<source src="../samples/video_180_TB.mp4" type="video/mp4"> | ||
</video> | ||
<ul> | ||
<li><a href="../">return to main example</a></li> | ||
</ul> | ||
<script src="../node_modules/video.js/dist/video.js"></script> | ||
<script src="../dist/videojs-vr.js"></script> | ||
<script> | ||
(function(window, videojs) { | ||
var player = window.player = videojs('videojs-vr-player'); | ||
player.mediainfo = player.mediainfo || {}; | ||
player.mediainfo.projection = '180_TB'; | ||
|
||
var vr = window.vr = player.vr({projection: '180_TB', debug: true, forceCardboard: false}); | ||
}(window, window.videojs)); | ||
</script> | ||
|
||
<script src="examples.js"></script> | ||
|
||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,5 +30,8 @@ | |
}); | ||
}(window, window.videojs)); | ||
</script> | ||
|
||
<script src="examples.js"></script> | ||
|
||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
|
||
<!doctype html> | ||
<html> | ||
<head> | ||
<meta charset="utf-8"> | ||
<title>videojs-vr Demo</title> | ||
<link href="../node_modules/video.js/dist/video-js.css" rel="stylesheet"> | ||
<link href="../dist/videojs-vr.css" rel="stylesheet"> | ||
</head> | ||
<body> | ||
<video width="640" height="300" id="videojs-vr-player" class="video-js vjs-default-skin" controls playsinline> | ||
<source src="../samples/cc_oceanside_beach.mp4" type="video/mp4"> | ||
</video> | ||
<ul> | ||
<li><a href="../">return to main example</a></li> | ||
</ul> | ||
<script src="../node_modules/video.js/dist/video.js"></script> | ||
<script src="../dist/videojs-vr.js"></script> | ||
<script> | ||
(function(window, videojs) { | ||
var player = window.player = videojs('videojs-vr-player'); | ||
player.mediainfo = player.mediainfo || {}; | ||
player.mediainfo.projection = '360'; | ||
|
||
// AUTO is the default and looks at mediainfo | ||
var vr = window.vr = player.vr({projection: '360_TB', debug: true, forceCardboard: false}); | ||
}(window, window.videojs)); | ||
</script> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* eslint-disable */ | ||
const videoSourceParam = window.location.search.substring(1); | ||
if (videoSourceParam) { | ||
if (videoSourceParam.indexOf(".mpd") !== -1) { | ||
player.src({ | ||
type: 'application/dash+xml', | ||
src: videoSourceParam | ||
}); | ||
} else if (videoSourceParam.indexOf(".m3u8") !== -1) { | ||
player.src({ | ||
type: 'application/vnd.apple.mpegurl', | ||
src: videoSourceParam | ||
}); | ||
} else { | ||
player.src({ | ||
type: 'video/mp4', | ||
src: videoSourceParam | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, testing locally, an upgrade to 170 seems OK when setting the color spaces manually. This was an explicit change in r152: https://discourse.threejs.org/t/updates-to-color-management-in-three-js-r152/50791
I think these should be all:
That doesn't have to happen as part of this PR though.