Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vendor threejs files #247

Merged
merged 10 commits into from
Aug 31, 2021
Merged

feat: vendor threejs files #247

merged 10 commits into from
Aug 31, 2021

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Aug 26, 2021

Copy the example files we depended on from an older version of threejs into a vendor directory and apply the rollup replace pieces directly to it.
This allows us to update to a newer version of threejs so that npm audit --production no longer produces any issues. We can't upgrade to newer versions of threejs until we update our tooling and likely start transpiling threejs as well, because by default it starts including new JS features in the build files.

Fixes #244.

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@gkatsev gkatsev merged commit 6a76537 into main Aug 31, 2021
@gkatsev gkatsev deleted the vendor-three branch August 31, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depends on vulnerable versions of three
2 participants