Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some typos #232

Merged
merged 1 commit into from
Jun 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

### Tests

* Add a test, fix the build, update generator verison ([#184](https://github.com/videojs/videojs-vr/issues/184)) ([17c7ee0](https://github.com/videojs/videojs-vr/commit/17c7ee0))
* Add a test, fix the build, update generator version ([#184](https://github.com/videojs/videojs-vr/issues/184)) ([17c7ee0](https://github.com/videojs/videojs-vr/commit/17c7ee0))

<a name="1.5.0"></a>
# [1.5.0](https://github.com/videojs/videojs-vr/compare/v1.4.7...v1.5.0) (2018-09-17)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ The most recent versions of:
* Firefox
* Safari
* Mobile
* Chrome on Andriod
* Chrome on Android
* Safari on iOS

## Projection support
Expand Down
2 changes: 1 addition & 1 deletion scripts/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const options = {
};
const config = generate(options);

// Add additonal builds/customization here!
// Add additional builds/customization here!

// export the builds to rollup
export default Object.values(config.builds);
8 changes: 4 additions & 4 deletions src/canvas-player-controls.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class CanvasPlayerControls extends videojs.EventTarget {

onMoveEnd(e) {

// We want to have the same behavior in VR360 Player and standar player.
// We want to have the same behavior in VR360 Player and standard player.
// in touchend we want to know if was a touch click, for a click we show the bar,
// otherwise continue with the mouse logic.
//
Expand All @@ -94,16 +94,16 @@ class CanvasPlayerControls extends videojs.EventTarget {
return;
}

// We want the same behavior in Desktop for VR360 and standar player
if(e.type == 'mouseup') {
// We want the same behavior in Desktop for VR360 and standard player
if (e.type == 'mouseup') {
this.togglePlay();
}

}

onMove(e) {

// Increase touchMoveCount_ since Android detects 1 - 6 touches when user click normaly
// Increase touchMoveCount_ since Android detects 1 - 6 touches when user click normally
this.touchMoveCount_++;

this.shouldTogglePlay = false;
Expand Down
2 changes: 1 addition & 1 deletion src/cardboard-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class CardboardButton extends Button {
// otherwise deactivate it
if (!this.active_) {
// This starts playback mode when the cardboard button
// is clicked on Andriod. We need to do this as the controls
// is clicked on Android. We need to do this as the controls
// disappear
if (!this.player_.hasStarted() && videojs.browser.IS_ANDROID) {
this.player_.play();
Expand Down
2 changes: 1 addition & 1 deletion src/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class VR extends Plugin {
}
if (projection === 'AUTO') {
// mediainfo cannot be set to auto or we would infinite loop here
// each source should know wether they are 360 or not, if using AUTO
// each source should know whatever they are 360 or not, if using AUTO
if (this.player_.mediainfo && this.player_.mediainfo.projection && this.player_.mediainfo.projection !== 'AUTO') {
const autoProjection = utils.getInternalProjectionName(this.player_.mediainfo.projection);

Expand Down