Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small screen issue #228

Closed
wants to merge 2 commits into from
Closed

fix small screen issue #228

wants to merge 2 commits into from

Conversation

thecuvii
Copy link

Description

In small screen, quality is bad. So I double render and effect size to get better quality.
also need #225

Specific Changes proposed

  1. add doubleSizeForSmallScreen function in utils.js, if currentWidth is small than videoWidth, double currentWidth and currentHeight.
  2. change render and effect size in plugin.js init function.
  3. change size in plugin.js handleResize_ function

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@thecuvii thecuvii marked this pull request as draft August 26, 2020 10:05
@thecuvii thecuvii closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant