feat: add an option to force cardboard button #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Aug 17, 2017
gkatsev
reviewed
Aug 17, 2017
src/plugin.js
Outdated
| @@ -451,7 +452,7 @@ class VR extends Plugin { | |||
| this.player_.addChild('BigVrPlayButton', {}, this.bigPlayButtonIndex_); | |||
| this.player_.bigPlayButton = this.player_.getChild('BigVrPlayButton'); | |||
| // mobile devices | |||
| if (videojs.browser.IS_ANDROID || videojs.browser.IS_IOS) { | |||
| if (videojs.browser.IS_ANDROID || videojs.browser.IS_IOS || this.options_.forceCardboard) { | |||
There was a problem hiding this comment.
in here, do we know if we're using native VR or not? Would be good to have it added for the firefox usecase.
There was a problem hiding this comment.
we actually might with something like this.vrDisplay.isPolyfilled
There was a problem hiding this comment.
we should do that then. Maybe in a another PR, though?
brandonocasey
force-pushed
the
feat/force-cardboard
branch
3 times, most recently
from
37583ff to
52ed1e4
Compare
brandonocasey
force-pushed
the
feat/force-cardboard
branch
from
52ed1e4 to
24c70ad
Compare
mister-ben
pushed a commit
to mister-ben/videojs-vr
that referenced
this pull request
Dec 4, 2023
three.js version revert back to v129 as 130 breaks renderer.getSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.