fix: use player resize/fullscreenchange events which are more consistent #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Jul 27, 2017
src/plugin.js
Outdated
| @@ -364,8 +364,7 @@ const vr = function(options) { | |||
| camera.updateProjectionMatrix(); | |||
| } | |||
|
|
|||
| window.addEventListener('resize', onWindowResize, false); | |||
| window.addEventListener('vrdisplaypresentchange', onWindowResize, true); | |||
| player.on(['resize', 'fullscreenchange'], onWindowResize); | |||
There was a problem hiding this comment.
the resize event means that the video has changed resolution. We don't currently have an event for the player changed size other than fullscreenchange, I don't think.
We probably still want to listen to resize and vrdisplaypresentchange on window. At least the vrdisplaypresentchange.
There was a problem hiding this comment.
I guess there isn't any harm in listening to all of these events (minus resize on player)
brandonocasey
force-pushed
the
fix/safari-fullscreen-toggle
branch
from
0e4a070 to
78782ff
Compare
gkatsev
approved these changes
Jul 27, 2017
brandonocasey
added a commit
that referenced
this pull request
Jul 27, 2017
kevleyski
referenced
this pull request
in kevleyski/videojs-vr
Dec 20, 2022
[KJSL] Swap webvr ro webxr polyfill packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified on Chrome, Safari, Firefox, Edge, and Android Chrome