test: add a test, and fix tests #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Aug 13, 2019
| } | ||
|
|
||
| return Component.prototype.cancelAnimationFrame.call(this, id); | ||
| return this.player_.cancelAnimationFrame(id); |
There was a problem hiding this comment.
I also noticed that we should just call player functions here, as we were getting some un-important errors, but errors none the less.
brandonocasey
commented
Aug 13, 2019
| @@ -39,7 +39,8 @@ module.exports = replace({ | |||
| code = globalReplace(code, 'rotateLeft', 'scope.rotateLeft'); | |||
| code = globalReplace(code, 'rotateUp', 'scope.rotateUp'); | |||
| // comment out the context menu prevent default line... | |||
| code = globalReplace(code, | |||
| code = globalReplace( | |||
There was a problem hiding this comment.
linter error, strange that it didn't come up until now.
brandonocasey
commented
Aug 13, 2019
| this.clock.tick(1); | ||
| }); | ||
|
|
||
| QUnit.test('playback', function(assert) { |
There was a problem hiding this comment.
similar to the vhs playback tests.
brandonocasey
commented
Aug 27, 2019
src/orbit-orientation-controls.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| import * as THREE from 'three'; | |||
| import {Vector3} from 'three'; | |||
There was a problem hiding this comment.
Specific imports
brandonocasey
force-pushed
the
test/add-a-test
branch
2 times, most recently
from
ee72bf2 to
9fdb5ff
Compare
brandonocasey
force-pushed
the
test/add-a-test
branch
from
9fdb5ff to
ac10887
Compare
gkatsev
reviewed
Aug 27, 2019
package.json
Outdated
| "three": "0.93.0", | ||
| "video.js": "^6 || ^7", | ||
| "video.js": "^7", |
There was a problem hiding this comment.
Ehh probably not, I will add it back in.
brandonocasey
force-pushed
the
test/add-a-test
branch
from
1c60ba1 to
1ad1933
Compare
brandonocasey
force-pushed
the
test/add-a-test
branch
from
1ad1933 to
b0bb145
Compare
gkatsev
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like tests are currently broken due to a dependency issue, this fixes them.
Closes #174
Closes #171
Closes #170
Closes #169
Closes #154
Closes #149
Closes #148
Closes #145
Closes #144
Closes #141
Closes #140