Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for detail level in projection sphere #225

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

campbellwmorgan
Copy link
Contributor

@campbellwmorgan campbellwmorgan commented Aug 18, 2020

Description

Currently the lack of detail in the underlying sphere mesh used in
equirectangular projections is very obvious and can cause visual
artifacts (a kind of wobble), especially noticeable at the poles.
See below:
image

Specific Changes proposed

Allow end user to increase the detail level of the sphere mesh.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

Currently the lack of detail in the underlying sphere mesh used in
equirectangular projections is very obvious and can cause visual
artifacts (a kind of wobble).

Increasing the detail level of the sphere can dramatically improve this
and it should therefore be provided as a customisation option
@brandonocasey brandonocasey merged commit 85ab8e9 into videojs:master Jun 14, 2021
brandonocasey pushed a commit that referenced this pull request Jun 14, 2021
…225)

Currently the lack of detail in the underlying sphere mesh used in
equirectangular projections is very obvious and can cause visual
artifacts (a kind of wobble).

Increasing the detail level of the sphere can dramatically improve this
and it should therefore be provided as a customization option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants