Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve an issue where 'error' events triggered on the player during contrib-ads playback would not be recognized. #109

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

misteroneill
Copy link
Member

The redispatch change in contrib-ads v5.0 means that all player events are redispatched during ad playback. In this case, this meant that some users would not see error dialog contents during ad playback if there was an error on the player. This addresses that situation by listening for both the aderror redispatch-prefixed event and the regular error event.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

…ring contrib-ads playback would not be recognized.
@marguinbc
Copy link

Question. If an actual ad error occurs, i.e. an IMA 1009 (empty ad response), will this change now cause the dialog box to pop up? Ad errors typically are only logged out to the console so seeing the popup would be an undesirable change.

@misteroneill
Copy link
Member Author

@marguinbc No, because those are triggered as adserror, not aderror. I wondered the same thing. 😄

@misteroneill misteroneill merged commit 3b48430 into master Sep 6, 2017
@misteroneill misteroneill deleted the ad-error branch September 6, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants