fix: Resolve an issue where 'error' events triggered on the player during contrib-ads playback would not be recognized. #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redispatch change in contrib-ads v5.0 means that all player events are redispatched during ad playback. In this case, this meant that some users would not see error dialog contents during ad playback if there was an error on the player. This addresses that situation by listening for both the
aderror
redispatch-prefixed event and the regularerror
event.Requirements Checklist