This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Add events for underflow and live resync #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For QoS measurement purposes, it may be useful to know how often the playback watcher is activating. Add new events for when the player falls off the back of the live window or stalls due to a video buffer gap.
gesinger
approved these changes
Feb 1, 2017
test/playback-watcher.test.js
Outdated
|
|
||
| currentTime = 12; | ||
| seekable[0] = [0, 100]; | ||
| buffered[0] = [0, 9]; |
There was a problem hiding this comment.
Minor, but can do buffered = [[0, 9], [10, 20]];
test/playback-watcher.test.js
Outdated
| buffered[0] = [0, 9]; | ||
| buffered.push([10, 20]); | ||
| playbackWatcher.waiting_(); | ||
| assert.equal(videounderflow, 1, 'triggered a videounderflow event'); |
There was a problem hiding this comment.
Might be worth verifying liveresync stays the same at the end.
Minor cleanup and an additional assertion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For QoS measurement purposes, it may be useful to know how often the playback watcher is activating. Add new events for when the player falls off the back of the live window or stalls due to a video buffer gap.