This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Map legacy AVC codecs to their modern equivalents when excluding inco… #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatible playlists
mjneil
reviewed
Dec 22, 2016
| @@ -72,6 +73,12 @@ const parseCodecs = function(codecs) { | |||
| return result; | |||
| }; | |||
|
|
|||
| export const mapLegacyAvcCodecs = (codecString) => { | |||
There was a problem hiding this comment.
This doesn't really affect anything since this function doesn't use this, but I think it's safer to not use arrow function syntax for top level functions just because it creates special behavior
dmlap
reviewed
Dec 22, 2016
| @@ -72,6 +73,12 @@ const parseCodecs = function(codecs) { | |||
| return result; | |||
| }; | |||
|
|
|||
| export const mapLegacyAvcCodecs = (codecString) => { | |||
There was a problem hiding this comment.
Why export this if it's only used in this module?
There was a problem hiding this comment.
Exported for unit tests
|
Updated |
mjneil
reviewed
Dec 22, 2016
| * @param codecString {String} the codec string | ||
| * @return {String} the codec string with old apple-style codecs replaced | ||
| */ | ||
| export const mapLegacyAvcCodecs = function(codecString) { |
There was a problem hiding this comment.
Can we add an underscore and @Private to this since we don't want this to be a part of the api that we are exposing
mjneil
reviewed
Dec 22, 2016
| @@ -7,6 +7,7 @@ import Ranges from './ranges'; | |||
| import videojs from 'video.js'; | |||
| import AdCueTags from './ad-cue-tags'; | |||
| import SyncController from './sync-controller'; | |||
| import { translateLegacyCodecs } from 'videojs-contrib-media-sources/es5/codec-utils'; | |||
There was a problem hiding this comment.
I think we should plan to not do a deep import in the future, but it is ok for now
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mpatible playlists
Requirements Checklist