This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Fix a segment hop in live #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a case where the live playlist updates during processing of the first segment request, it is possible that we'd skip over the next segment and proceed down the playlist. This accounts for the change in media sequence during update end.
|
LGTM (jumped the gun a bit on this one) |
mjneil
reviewed
Dec 16, 2016
| let currentMediaIndex = segmentInfo.mediaIndex; | ||
|
|
||
| currentMediaIndex += | ||
| segmentInfo.playlist.mediaSequence - this.playlist_.mediaSequence; | ||
|
|
||
| if (!segmentInfo.isSyncRequest) { |
There was a problem hiding this comment.
Can we actually get to this check if the segment is a sync request? In handleSegment_ we return if it is a sync request and never append, so I would think this check is unnecessary.
There was a problem hiding this comment.
I think Matt means "Can we actually get rid of this check" which I agree with!
|
LGTM official this time |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a case where the live playlist updates during processing of the first segment request, it is possible that we'd skip over the next segment and proceed down the playlist. This accounts for the change in media sequence during update end.
Requirements Checklist