This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Add a page to help debug the transmuxing process #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging transmux issues, it can be handy to be able to easily compare the result of the javascript segment parser with the working output from a tool like ffmpeg. Put together a test page to display the hex dump of segment-parser output side-by-side with a working example. Fixed the hex dump utility to produce more than one line of output per tag.
Add rules to exclude the muxing utility page from jshint and qunit.
Avoid using one-letter variable names, especially in relatively complex functions.
Get rid of a commented console.assert that had been replaced by a runtime conditional anyways.
Make sure that a reasonable sequence parameter set can be decoded.
The original algorithm was incorrectly including the nal_unit_type in the returned RBSP when there were no emulation bytes to filter. This version is slower because it examines every byte individually but it's simpler to understand. Add a test case for H264 stream parsing that demonstrates the issue.
List the type and size of each tag of the input FLVs on the muxing helper page.
Remove an extra semi-colon and refrence videojs through window.
Overwrite setNextTimeStamp after the first invocation, capturing the first PTS value. Write all FLV PTS and DTS values as offsets from that.
Don't append to the tag info pane. Overwrite the innerHTML whenever one of the files change.
| @@ -1,5 +1,12 @@ | |||
| (function(window) { | |||
|
|
|||
| if (!window.videojs) { | |||
There was a problem hiding this comment.
why not just
window.videojs = window.videojs || {};
window.videojs.hls = window.videojs.hls || {};Instead of using a conditional, use logical or when determining if videojs.hls should be stubbed out or not.
dmlap
added a commit
that referenced
this pull request
Mar 11, 2014
Add a page to help debug the transmuxing process
This was referenced Mar 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a test page that makes it slightly easier to look at the generated FLV tags from the segment parser.
Fix a parsing issue with NAL units ending and IDRs. Fix an issue where negative PTS values at the MP2T level would result in PTS and DTS values of zero on all FLV tags.