Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Split generic-seeming functionality into their own files #1217

Closed
wants to merge 2 commits into from

Conversation

OshinKaramian
Copy link
Contributor

Description

This is in response to @mjneil's comment in #1212 (comment).

This is really just reorganizing to pull some of the more common/generic functionality from master-playlists-controller.js out into their own files. I'm sure more can be pulled from other files as well (I haven't dug deep enough to know).

No logic changes, just shuffling some functions around.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@mjneil
Copy link
Contributor

mjneil commented Jul 31, 2017

Does the codec test get run properly with npm run test? i think util/codecs.js needs util/codecs.test.js

@OshinKaramian
Copy link
Contributor Author

Whoops, I didn't realize that that's how tests were run (I assumed it was picking out anything with Qunit in the test folder and running it). Should be resolved on the latest commit.

@mjneil
Copy link
Contributor

mjneil commented Aug 8, 2017

would it make sense to move the bin-utils.js file to util/bin.js?

@OshinKaramian
Copy link
Contributor Author

Closing this, as it will cause conflicts when moving to videojs/http-streaming. Refactor PRs should probably go in there as this project is deprecated in favor of videojs/http-streaming.

@OshinKaramian OshinKaramian deleted the utils branch January 24, 2018 21:39
@OshinKaramian
Copy link
Contributor Author

Reference: videojs/http-streaming#17 for similar changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants