This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
don't crash when segment metadata cues can't be created #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Jun 16, 2017
src/segment-loader.js
Outdated
| @@ -1086,6 +1086,11 @@ export default class SegmentLoader extends videojs.EventTarget { | |||
| const start = segment.start; | |||
| const end = segment.end; | |||
|
|
|||
| // Do not try adding the cue if the start and end times are invalid. | |||
| if (!Number.isFinite(start) || !Number.isFinite(end)) { | |||
There was a problem hiding this comment.
isFinite is not supported in IE. Do we have a polyfill for it?
gesinger
approved these changes
Jun 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bad segment might trip up our segment probe. When trying to create the metadata cue for that segment, the player can crash. We shouldn't disrupt playback for something non-essential to playback
#1165