This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Do not reset segmentloaders when switching media groups #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Jun 8, 2017
| @@ -295,10 +301,11 @@ QUnit.test('fast quality change resyncs audio segment loader', function(assert) | |||
| assert.equal(this.requests.length, 1, 'one request'); | |||
| masterPlaylistController.fastQualityChange_(); | |||
| assert.equal(this.requests.length, 2, 'added a request for new media'); | |||
| assert.equal(resets, 0, 'does not reset the audio segment loader yet'); | |||
| assert.equal(resyncs, 0, 'does not resyncs the audio segment loader yet'); | |||
| masterPlaylistController.fastQualityChange_(); | ||
| assert.equal(resets, 0, 'does not reset the audio segment loader when media same'); | ||
| assert.equal(resyncs, 0, 'does not resyncs the audio segment loader when media same'); |
mjneil
approved these changes
Jun 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When switching media-groups we do not need to reset the SegmentLoaders. Doing so causes us to evict all audio (and/or video) data from the source buffers which causes poor user experience when switching renditions that reference different media-groups.
Specific Changes proposed
abortwould leave it in a bad statedisposewould leave the monitor buffer timer runningsetupAudiointo several functions so that they can be combined into two different work-flows -setupAudiowhich does a hard-reset of the SegmentLoaders andmediaGroupsChangedwhich does not