This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Add text tracks for closed captions listed in playlist #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squarebracket
force-pushed
the
add-text-tracks-for-captions
branch
from
8e485de to
3983db2
Compare
mjneil
approved these changes
Aug 7, 2017
|
Blocked on |
mjneil
reviewed
Aug 11, 2017
src/master-playlist-controller.js
Outdated
| enabled: false, | ||
| language: properties.language, | ||
| label | ||
| }, true).track; |
There was a problem hiding this comment.
If we change this parameter from true to false, video.js will take care of removing the track on source changes
There was a problem hiding this comment.
derp derp, thanks.
|
just found a problem -- need to ignore CEA708 tracks since we don't support them. |
|
Oh those can be specified in manifest as well. Is there a way to tell them apart in manifest? |
|
Yeah, by inspecting the value of |
squarebracket
force-pushed
the
add-text-tracks-for-captions
branch
3 times, most recently
from
a98050e to
9e571f0
Compare
added to fix duplicate caption processing problem
squarebracket
force-pushed
the
add-text-tracks-for-captions
branch
from
9e571f0 to
013ff8b
Compare
|
I'm doing some manual testing and I'm getting a 708 track added, looking into it... |
|
Nevermind.. Was mistakenly using wrong code 🙄 |
mjneil
approved these changes
Aug 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, text tracks for captions are created by
videojs-contrib-media-sources. With the open PRs for multiple caption
track support in mux.js
and contrib-media-sources
text tracks are simply created using their caption track (
CCn). ThisPR creates tracks at playlist read time. Afterwards, contrib-media-sources will look to see if a text track that has the ID of
CCnexists, and if so, it will use that track.Specific Changes proposed
Right after subtitle text tracks are created, closed caption text tracks are created.
Requirements Checklist