fix(videojs-dash): currentTime with DVR live stream #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
currentTime
function to keep consistency withHttp-Streaming
. ThecurrentTime
function when used with live streams has two problems:timestamp
instead ofseconds
timestamp
instead ofseconds
Screencast.from.17.05.23.16.20.40.webm
Use Case
A developer wishing to redefine the position will have to use a timestamp instead of a position expressed in seconds.
To reproduce the problem open videojs-contrib-dash and in the developer console copy-paste the code below:
Specific Changes proposed
tech_
currentTime
,setCurrentTime
andseekable
functions to support livescurrentTime
, returns the position expressed in secondssetCurrentTime
, takes as a parameter a position expressed in secondsseekable
, returns a range expressed in secondsRequirements Checklist