chore: Update typescript and jsdoc, use @import #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8723 +/- ##
==========================================
+ Coverage 83.15% 83.83% +0.68%
==========================================
Files 120 120
Lines 7995 7995
Branches 1924 1924
==========================================
+ Hits 6648 6703 +55
+ Misses 1347 1292 -55 ☔ View full report in Codecov by Sentry. |
gkatsev
approved these changes
May 14, 2024
gkatsev
reviewed
May 14, 2024
| @@ -4703,7 +4706,7 @@ class Player extends Component { | |||
| * from the TextTrackList and HtmlTrackElementList | |||
| * after a source change | |||
| * | |||
| * @return { import('./tracks/html-track-element').default } | |||
| * @return {HtmlTrackElement} | |||
There was a problem hiding this comment.
actually makes the jsdoc more informative here https://deploy-preview-8723--videojs-docs.netlify.app/player#addRemoteTextTrack vs https://videojs-docs.netlify.app/player#addRemoteTextTrack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beta, because 5.5.0 supports better syntax for importing types in jsdoc. (In VSCode, use "TypeScript: Select TypeScript version" to use the "workspace version"){ import('./file').default}syntax, which jsdoc itself doesn't support.