-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): update videojs-contrib-quality-levels to 4.0.0 to eliminate deprecation warning #8303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing and I wonder if the cause is that different versions of Node and npm were used than are expected for the build.
I did the upgrade locally and everything works with minimal changes to the package-lock.json
. Here's the entire diff when I use Node 14 and npm 6:
diff --git a/package-lock.json b/package-lock.json
index 3b9d2c46..f43a1cc2 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -15224,13 +15224,21 @@
}
}
}
+ },
+ "videojs-contrib-quality-levels": {
+ "version": "3.0.0",
+ "resolved": "https://registry.npmjs.org/videojs-contrib-quality-levels/-/videojs-contrib-quality-levels-3.0.0.tgz",
+ "integrity": "sha512-sNx38EYUx+Q+gmup1gVTv9P9/sPs28rM7gZOx1sedaHoKxEdYB+ysOGfHj6MSELBMNGMj6ZspdrpSiWguGvGxA==",
+ "requires": {
+ "global": "^4.4.0"
+ }
}
}
},
"videojs-contrib-quality-levels": {
- "version": "3.0.0",
- "resolved": "https://registry.npmjs.org/videojs-contrib-quality-levels/-/videojs-contrib-quality-levels-3.0.0.tgz",
- "integrity": "sha512-sNx38EYUx+Q+gmup1gVTv9P9/sPs28rM7gZOx1sedaHoKxEdYB+ysOGfHj6MSELBMNGMj6ZspdrpSiWguGvGxA==",
+ "version": "4.0.0",
+ "resolved": "https://registry.npmjs.org/videojs-contrib-quality-levels/-/videojs-contrib-quality-levels-4.0.0.tgz",
+ "integrity": "sha512-u5rmd8BjLwANp7XwuQ0Q/me34bMe6zg9PQdHfTS7aXgiVRbNTb4djcmfG7aeSrkpZjg+XCLezFNenlJaCjBHKw==",
"requires": {
"global": "^4.4.0"
}
diff --git a/package.json b/package.json
index b7ace26d..8589072b 100644
--- a/package.json
+++ b/package.json
@@ -96,7 +96,7 @@
"mpd-parser": "^1.0.1",
"mux.js": "^6.2.0",
"safe-json-parse": "4.0.0",
- "videojs-contrib-quality-levels": "3.0.0",
+ "videojs-contrib-quality-levels": "^4.0.0",
"videojs-font": "4.1.0",
"videojs-vtt.js": "0.15.4"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and pushed up a fix here because we do want to get this in. The issue was that a version other than Node 14 and npm 6 was used and the package-lock.json
was significantly changed.
Using the expected version of Node/npm resolved the test failures.
Codecov Report
@@ Coverage Diff @@
## main #8303 +/- ##
=======================================
Coverage 82.56% 82.56%
=======================================
Files 112 112
Lines 7495 7495
Branches 1808 1808
=======================================
Hits 6188 6188
Misses 1307 1307 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
Fixed a warning when using quality-levels 3.x which used mergeOptions. It prepare for 9.0.0
Specific Changes proposed
update videojs-contrib-quality-levels to ^4.0.0 in package.json
Requirements Checklist