fix: regression with AD audio track menu items #7559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #7337, a lot of code was updated to no longer user innerHTML, but we accidentally caused an issue with Audio Description (AD) tracks where the track title was included twice. Once before and once after the AD icon. This is because we were calling `super.createEl()` but MenuItem created a specific element and didn't just pass things the arguments along. Instead, we should use `Dom.createEl()` directly. Fixes #7556
Codecov Report
@@ Coverage Diff @@
## main #7559 +/- ##
=======================================
Coverage 80.24% 80.24%
=======================================
Files 116 116
Lines 7324 7324
Branches 1770 1770
=======================================
Hits 5877 5877
Misses 1447 1447
Continue to review full report at Codecov.
|
misteroneill
approved these changes
Dec 8, 2021
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
In videojs#7337, a lot of code was updated to no longer user innerHTML, but we accidentally caused an issue with Audio Description (AD) tracks where the track title was included twice. Once before and once after the AD icon. This is because we were calling `super.createEl()` but MenuItem created a specific element and didn't just pass things the arguments along. Instead, we should use `Dom.createEl()` directly. Fixes videojs#7556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7337, a lot of code was updated to no longer user innerHTML, but we
accidentally caused an issue with Audio Description (AD) tracks where
the track title was included twice. Once before and once after the AD
icon.
This is because we were calling
super.createEl()but MenuItem createda specific element and didn't just pass things the arguments along.
Instead, we should use
Dom.createEl()directly.Fixes #7556