Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add breakpoints option to support toggling classes based on player width. #5471

Merged
merged 7 commits into from
Oct 10, 2018
+473 −45
Merged

feat: Add breakpoints option to support toggling classes based on player width. #5471

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3d7558
feat: Add breakpoints option to support toggling classes based on pla…
misteroneill Oct 2, 2018
4050444
Update responsive.html.example with latest
misteroneill Oct 2, 2018
fa01715
Updates based on CR
misteroneill Oct 4, 2018
2af5767
Tests
misteroneill Oct 4, 2018
0f9fa4f
CR
misteroneill Oct 9, 2018
57f53c1
CR
misteroneill Oct 10, 2018
53d0785
CR
misteroneill Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CR
@misteroneill
misteroneill committed Oct 10, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
commit 57f53c17d212a3b15e18c40dee501b34c2f0f252
4 changes: 2 additions & 2 deletions src/css/components/_adaptive.scss
View file
Original file line number Diff line number Diff line change
@@ -29,12 +29,12 @@
// - Play button
// - Progress bar
// - Volume menu button
// - Captions Button
// - Subs-Caps Button
// - Fullscreen button
.video-js.vjs-layout-small:not(.vjs-fullscreen) {
.vjs-current-time, .vjs-time-divider, .vjs-duration, .vjs-remaining-time,
.vjs-playback-rate,
.vjs-mute-control, .vjs-volume-control, .vjs-volume-panel,
.vjs-chapters-button, .vjs-descriptions-button, .vjs-captions-button,
.vjs-subtitles-button, .vjs-subs-caps-button, .vjs-audio-button { display: none; }
.vjs-subtitles-button, .vjs-audio-button { display: none; }
}
2 changes: 1 addition & 1 deletion src/css/components/_control-bar.scss
View file
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@

// Video has started playing
.vjs-has-started .vjs-control-bar {
@include display-flex;
@include display-flex(flex-start, space-between);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to the justification should be fine. For all sizes except tiny, the progress bar fills all available space, making the justification pretty much irrelevant. This seems like the right value for other use-cases (without a progress bar).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the issue is that the spacer has different settings applied to it in tiny mode:

   .vjs-custom-control-spacer { @include flex(auto); }
   &.vjs-no-flex .vjs-custom-control-spacer { width: auto; }

I'd be more comfortable fiddling with those properties over this one, at first at least.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sure.

visibility: visible;
opacity: 1;