fix: call component dispose in resize manager to fix leak #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also probably want to turn off touch activity for the resize manager. |
|
sure, I wasn't sure if it needed it or not. |
gkatsev
pushed a commit
that referenced
this pull request
Aug 13, 2018
Because we add Touch Activity in the parent class and those don't actually get removed in Resize Manager we leak on every dispose. Calling super.dispose() cleans them up because we remove our list of handlers via a call to DomData.removeData Fixes #5339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most event listeners that are being added are not removed because we don't trigger dispose in the ResizeManager. I think that it makes sense to just call the parents dispose here instead though.
EDIT: More Info:
Because we add Touch Activity in the parent class and those don't actually get removed in Resize Manager we leak on every dispose. Calling
super.dispose()cleans them up because we remove our list of handlers via a call toDomData.removeData