refactor player.dimension() #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4706 currently fail |
gkatsev
reviewed
Oct 31, 2017
| @@ -656,17 +656,16 @@ class Player extends Component { | |||
| if (value === '') { | |||
| // If an empty string is given, reset the dimension to be automatic | |||
| this[privDimension] = undefined; | |||
| } else { | |||
| const parsedVal = parseFloat(value); | |||
There was a problem hiding this comment.
why not keep this variable? Then we won't need to parseFloat twice?
|
I fixed master build and reran the tests here and it's passing now :) |
gkatsev
approved these changes
Nov 1, 2017
misteroneill
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements Checklist