fix: make boolean attributes set and check both the associated property and the attribute #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4351 |
This was referenced Aug 11, 2017
src/js/utils/dom.js
Outdated
| @@ -375,7 +375,7 @@ export function getAttributes(tag) { | |||
| // known boolean attributes | |||
| // we can check for matching boolean properties, but older browsers | |||
| // won't know about HTML5 boolean attributes that we still read from | |||
| const knownBooleans = ',' + 'autoplay,controls,loop,muted,default' + ','; | |||
| const knownBooleans = ',' + 'autoplay,controls,playsinline,loop,muted,default' + ','; | |||
There was a problem hiding this comment.
Should default here be defaultMuted?
There was a problem hiding this comment.
I think this is supposed to be default because <track> els use a default attribute. Going to add defaultMuted in here.
atefBB
pushed a commit
to atefBB/video.js
that referenced
this pull request
Aug 16, 2017
…ty and the attribute (videojs#4562) Make boolean attributes like muted set the property video.muted = {{boolean}} and the attribute video.setAttribute('muted', 'muted') when changing the value. Also, in html5's createEl, we were setting/updating attributes for various properties but we were only setting the attributes and not also the properties but also autoplay was happening first rather than last which caused autoplay to fail because muted and playsinline weren't necessary set by that time. Fix videojs#4351.
7 tasks
gkatsev
added a commit
that referenced
this pull request
Sep 26, 2017
…ty and the attribute
Make boolean attributes like muted set the property video.muted = {{boolean}} and the attribute video.setAttribute('muted', 'muted') when changing the value.
Also, in html5's createEl, we were setting/updating attributes for various properties but we were only setting the attributes and not also the properties but also autoplay was happening first rather than last which caused autoplay to fail because muted and playsinline weren't necessary set by that time.
This is the 5.x version of #4562.
Fix #4351.
misteroneill
pushed a commit
that referenced
this pull request
Oct 2, 2017
…ty and the attribute (#4631) Make boolean attributes like muted set the property video.muted = {{boolean}} and the attribute video.setAttribute('muted', 'muted') when changing the value. Also, in html5's createEl, we were setting/updating attributes for various properties but we were only setting the attributes and not also the properties but also autoplay was happening first rather than last which caused autoplay to fail because muted and playsinline weren't necessary set by that time. This is the 5.x version of #4562. Fix #4351.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is quite complete yet but this is the initial implementation for making boolean attributes like
mutedset the propertyvideo.muted = {{boolean}}and the attributevideo.setAttribute('muted', 'muted')when changing the value.Also, in html5's createEl, we were setting/updating attributes for various properties but we were only setting the attributes and not also the properties but also autoplay was happening first rather than last which caused autoplay to fail because
mutedandplaysinlineweren't necessary set by that time.