Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safari picture-in-picture triggers fullscreenchange (5.x) #4442

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

mister-ben
Copy link
Contributor

Description

When picture-in-picture mode is entered on Safari, webkitbeginfullscreen is triggered which results in a proxied fullscreenchange event and adding the fullscreen class to the player. That causes the tech element to collapse to zero height so that the "this video is playing in picture in picture" placeholder is not visible.

Specific Changes proposed

As with #4437 for v6, on webkitbeginfullscreen check whether the presentation mode is picture-in-picture' before proxying a fullscreenchange` event.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Reviewed by Two Core Contributors

@gkatsev gkatsev added the 5.x label Jun 26, 2017
@gkatsev gkatsev merged commit c17c003 into videojs:5.x Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants