Allow 'playsinline' player option #4325
Conversation
|
I assume this will need a sister PR in |
src/js/player.js
Outdated
| * Get or set the playsinline attribute. | ||
| * | ||
| * @param {boolean} [value] | ||
| * - true means that we should play inline in iOS Safari |
There was a problem hiding this comment.
I would change these two say set the playsinline attribute or unset it. And mention above that this probably only applies on ios right now.
src/js/tech/html5.js
Outdated
| @@ -1235,6 +1235,20 @@ Html5.resetMediaElement = function(el) { | |||
| 'autoplay', | |||
|
|
|||
| /** | |||
| * Get the value of `playsinline` from the media element. `playsinline` indicates | |||
| * that the media should play inline in iOS Safari. | |||
There was a problem hiding this comment.
iOS is an example of a browser that will only play inline if the attribute is present.
src/js/tech/html5.js
Outdated
| @@ -1518,6 +1532,19 @@ Html5.resetMediaElement = function(el) { | |||
| 'autoplay', | |||
|
|
|||
| /** | |||
| * Set the value of `playsinline` on the media element. `playsinline` indicates | |||
|
Also, yes, a PR against master would be good. Can be done once this PR is approved, though. |
|
@alex-barstow While testing, I found that if I have a video embed with Also, we should add an |
src/js/tech/html5.js
Outdated
| * | ||
| * @see [Spec]{@link https://html.spec.whatwg.org/#attr-video-playsinline} | ||
| */ | ||
| Html5.prototype.playsinline = function() { |
There was a problem hiding this comment.
you should move these up and use the class syntax
src/js/tech/html5.js
Outdated
| @@ -1553,6 +1574,30 @@ Html5.resetMediaElement = function(el) { | |||
| }; | |||
| }); | |||
|
|
|||
| // This setter is declared outside of the loop because there is no 'playsinline' | |||
There was a problem hiding this comment.
We can just describe this in the PR instead, don't think it's necessary, especially if we move it into the class syntax.
| @@ -2381,6 +2382,29 @@ class Player extends Component { | |||
| } | |||
|
|
|||
| /** | |||
| * Set or unset the playsinline attribute. | |||
| * Playsinline tells the browser that non-fullscreen playback is preferred. | |||
| * | |||
|
@gkatsev @alex-barstow Should we have any testing like https://github.com/videojs/video.js/blob/master/test/unit/player.test.js#L94 where we make sure |
|
@imbcmdth Perhaps adding it would be useful, but the tests are already testing that if attributes are present they persist when videojs wraps the video element. |
|
@alex-barstow would you be able to make the sister PR against master for this as well? |
Description
Video.js players can accept a number of standard
<video>element options (autoplay,muted,loop, etc), but not currentlyplaysinline, which is now part of the HTML spec. We should add it to the list of<video>attributes that can be provided to the player as options.Specific Changes proposed
Update the
Html5andPlayerclasses with getter and setter methods forplaysinlineand make a few other additions to ensure that theplaysinlineoption works the same way as the other<video>element options.Requirements Checklist