fix: removeCue with native/same cues #4208

brandonocasey · 2017-03-16T18:36:23Z

Description

This PR fixes two issues:

If you add two of the same cues to the cues list they will both be removed by one call to removeCue
If you create an add a native cue to the cues list. You cannot use the native cue to remove the cue that was added to the cue list.

Feature implemented / Bug fixed
If necessary, more likely in a feature request than a bug fix
- Unit Tests updated or fixed
Reviewed by Two Core Contributors

gkatsev

One minor comment, LGTM otherwise.

gkatsev · 2017-03-23T15:48:10Z

src/js/tracks/text-track.js

        this.cues_.splice(i, 1);
-        removed = true;
+        this.cues.setCues_(this.cues_);
+        return;


probably more appropriate to use break here.

brandonocasey force-pushed the fix/remove-cue branch from ce43996 to b449fd8 Compare March 16, 2017 18:45

fix: use cue that was passed to addCue to removeCue

7cae903

brandonocasey force-pushed the fix/remove-cue branch from b449fd8 to 7cae903 Compare March 16, 2017 18:48

brandonocasey changed the title ~~fix: use cue that was passed to addCue to removeCue~~ fix: removeCue with native/same cues Mar 16, 2017

gkatsev approved these changes Mar 23, 2017

View reviewed changes

use break instead of return

137d849

brandonocasey merged commit f2b5a05 into master Mar 23, 2017

gkatsev deleted the fix/remove-cue branch March 24, 2017 22:34