Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Patch a memory leak caused by un-removed track listener(s). #3975

Merged
merged 1 commit into from
Feb 7, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/js/tech/tech.js
Original file line number Diff line number Diff line change
Expand Up @@ -589,20 +589,20 @@ class Tech extends Component {
return;
}

this.remoteTextTracks().on('addtrack', (e) => {
this.textTracks().addTrack_(e.track);
});
const remoteTracks = this.remoteTextTracks();
const handleAddTrack = (e) => tracks.addTrack_(e.track);
const handleRemoveTrack = (e) => tracks.removeTrack_(e.track);

this.remoteTextTracks().on('removetrack', (e) => {
this.textTracks().removeTrack_(e.track);
});
remoteTracks.on('addtrack', handleAddTrack);
remoteTracks.on('removetrack', handleRemoveTrack);

// Initially, Tech.el_ is a child of a dummy-div wait until the Component system
// signals that the Tech is ready at which point Tech.el_ is part of the DOM
// before inserting the WebVTT script
this.on('ready', this.addWebVttScript_);

const updateDisplay = () => this.trigger('texttrackchange');

const textTracksChanges = () => {
updateDisplay();

Expand All @@ -620,7 +620,15 @@ class Tech extends Component {
tracks.addEventListener('change', textTracksChanges);

this.on('dispose', function() {
remoteTracks.off('addtrack', handleAddTrack);
remoteTracks.off('removetrack', handleRemoveTrack);
tracks.removeEventListener('change', textTracksChanges);

for (let i = 0; i < tracks.length; i++) {
const track = tracks[i];

track.removeEventListener('cuechange', updateDisplay);
}
});
}

Expand Down