Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a Modal Dialog guide. #3961

Merged
merged 3 commits into from
Jan 25, 2017

Conversation

misteroneill
Copy link
Member

This adds a modal dialog guide based on the Brightcove document, provided by @mboles

Requirements Checklist

  • Document created
  • Reviewed by Two Core Contributors

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment LGTM otherwise

* [Example Using the ModalDialog Constructor](#example-using-the-modaldialog-constructor)
* [Styling Modals Independently](#styling-modals-independently)

## Creating the ModalDialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "Creating a ModalDialog"?

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @brandonocasey's comment. LGTM otherwise.

@brandonocasey brandonocasey merged commit 7b0d738 into videojs:master Jan 25, 2017
@misteroneill misteroneill deleted the modal-dialog-guide branch January 26, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants