Restore all outlines #3829
Merged
Restore all outlines #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
force-pushed
the
outlines
branch
2 times, most recently
from
4e630b5 to
8206b23
Compare
brandonocasey
approved these changes
Dec 6, 2016
misteroneill
force-pushed
the
outlines
branch
from
860a7a2 to
a080f17
Compare
misteroneill
commented
Dec 6, 2016
| @@ -24,7 +24,6 @@ | |||
| border: 0; | |||
| clip: rect(0 0 0 0); | |||
| height: 1px; | |||
| margin: -1px; | |||
There was a problem hiding this comment.
For reasoning behind this, see a080f17ebd2ef291a5f0d984f9cdbd106691a733
There was a problem hiding this comment.
seems like a reasonable change, still LGTM
|
Added one more commit to this PR. |
This looks like it was copy/pasted from HTML5 Boilerplate, but there does not seem to be a purpose to the `margin: -1px;` line and it causes unsightly "bumps" in the outline of certain elements (sliders). I browsed through 5 years of history of HTML5 Boilerplate and gave up looking for a justification for this. The WebAIM link they even used to cite (and the snook.ca link they currently cite) does not mention having this margin: http://webaim.org/techniques/css/invisiblecontent/
misteroneill
force-pushed
the
outlines
branch
from
a080f17 to
d10d6c8
Compare
gkatsev
approved these changes
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores outlines for everything for accessibility purposes.
The progress bar looks awkward, but I will be working on that in another PR.
Requirements Checklist