Remove custom UMD #3826
Merged
Remove custom UMD #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Dec 2, 2016
| } else if (typeof exports === 'object' && typeof module === 'object') { | ||
| module.exports = videojs; | ||
| } | ||
|
|
||
| export default videojs; |
There was a problem hiding this comment.
we need to change this do module.exports = videojs. Some things don't work right otherwise.
brandonocasey
approved these changes
Dec 5, 2016
misteroneill
force-pushed
the
remove-umd
branch
from
ad1136b to
9f4f884
Compare
Merged
misteroneill
force-pushed
the
remove-umd
branch
from
9f4f884 to
a256108
Compare
gkatsev
approved these changes
Dec 29, 2016
|
Fixes #2478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change for 6.0 - Browserify provides a UMD wrapper for us.
Requirements Checklist