fix: remove sourcemaps from the output #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
force-pushed
the
remove-sourcemaps
branch
from
036fbed to
d3700ab
Compare
misteroneill
approved these changes
Oct 24, 2016
|
Yeah, we can try and figure out sourcemaps in the future. But frankly, I've yet to have found real benefit from having sourcemaps. |
|
Benefit is quite great - being able to step through the code looking for potential problems. You should seriously consider using gulp - will build your code faster and would not require you to transpile/build to fs. It is not as bad as you think. |
gkatsev
force-pushed
the
remove-sourcemaps
branch
from
d3700ab to
6e17837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source Maps, while nice, aren't perfect and the ones we were outputting
weren't right.
Fixes #3701, #3106.