Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove es2015-loose since it's an option for es2015 #3629

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Sep 20, 2016

Description

Followup from #3609. es2015-loose is deprecated because it's available as an option on the es2015 preset.

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the unit tests failing?

@gkatsev
Copy link
Member Author

gkatsev commented Sep 20, 2016

Not sure. I'll take a look.

@brandonocasey
Copy link
Contributor

well the unit test failure is definitely odd...

@gkatsev
Copy link
Member Author

gkatsev commented Sep 21, 2016

The test is broken because classList in firefox no longer throws an error.

@gkatsev gkatsev added this to the 5.12 milestone Sep 27, 2016
@gkatsev gkatsev merged commit c545acd into videojs:master Sep 29, 2016
@gkatsev gkatsev deleted the es2015-loose branch September 29, 2016 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants